Skip to content

Conversation

Kocal
Copy link
Member

@Kocal Kocal commented Aug 19, 2025

Q A
Bug fix? no
New feature? no
Docs? no
Issues Fix #3009
License MIT

This pull request updates the browser testing workflow and related configuration to improve reliability, consistency, and maintainability across UX packages. The main changes include refactoring the browser test workflow to use a matrix strategy for Symfony versions, standardizing dependency installation steps, removing unused dependencies, and renaming the Playwright configuration for easier reuse.

Workflow and CI improvements:

  • Refactored .github/workflows/browser-tests.yml to use a matrix strategy for Symfony versions, added concurrency controls to cancel in-progress runs, and split setup steps for JS and PHP dependencies, Docker containers, and E2E app configuration. Artifact uploads now only occur on browser test failures. [1] [2]
  • Standardized JS dependency installation across workflows by replacing direct pnpm install commands with named steps (Install root JS dependencies) in code quality, unit test, dist files, and release workflows. [1] [2] [3] [4] [5] [6]

Testing and configuration changes:

  • Updated package.json to run browser tests in all workspaces concurrently, removed the unused webdriverio dependency, and improved the test:browser script for workspace aggregation. [1] [2]
  • Renamed playwright.config.ts to playwright.config.base.ts, added documentation for usage in UX packages, and improved test matching patterns and output directory configuration. [1] [2]

Dependency management:

These changes make the browser testing workflow more robust and maintainable, ensure consistent dependency installation, and clean up unused or optional packages to streamline CI runs.

@Kocal Kocal self-assigned this Aug 19, 2025
@carsonbot carsonbot added the Status: Needs Review Needs to be reviewed label Aug 19, 2025
@carsonbot carsonbot changed the title Create E2E app Create E2E app Aug 19, 2025
@Kocal Kocal changed the title Create E2E app Create E2E app for browsers tests Aug 19, 2025
@Kocal Kocal force-pushed the 3009-create-e2e-app branch 13 times, most recently from 1cb3116 to 413ec25 Compare August 19, 2025 18:30
@Kocal Kocal force-pushed the 3009-create-e2e-app branch from 413ec25 to dd1c13a Compare August 19, 2025 18:31
run: |
echo 'APP_ENV=prod' >> .env.local
echo 'APP_DEBUG=0' >> .env.local
echo 'APP_SECRET=df4c071596e64cc75a349456f2887ae2419ae650' >> .env.local
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥚

@Kocal Kocal merged commit 9d62749 into symfony:2.x Aug 19, 2025
30 of 33 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Needs Review Needs to be reviewed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create dedicated Symfony app for E2E tests
2 participants